Fix to readthedocs builds #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5_hotfix #336 +/- ##
===============================================
Coverage 55.74% 55.74%
===============================================
Files 15 15
Lines 3310 3310
===============================================
Hits 1845 1845
Misses 1465 1465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
w-k-jones
approved these changes
Sep 8, 2023
w-k-jones
added
documentation
11 tasks
|
Given that this is definitely working, I'm happy for this to be merged with a single review if you are @freemansw1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue with readthedocs builds discovered with #335.
We, incidentally, talked about this today. See: https://blog.readthedocs.com/drop-support-system-packages/ . While we had to deal with some of the consequences of this earlier, we now have the new issue of
system_packages: truein our readthedocs config, breaking readthedocs builds. This PR should alleviate that issue.In my mind, this is now a blocking PR, and 1.5.1 shouldn't be released until this is merged or the issue is resolved in some other way.